-
Notifications
You must be signed in to change notification settings - Fork 30
Complete the update to latest Terrajet version #128
Conversation
Signed-off-by: Hasan Turken <[email protected]> (cherry picked from commit 9219249ee6584bf06ca6577ea1f969e379b57dd0)
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
…me files we need Signed-off-by: Muvaffak Onus <[email protected]>
…iles Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
@@ -65,7 +65,7 @@ fallthrough: submodules | |||
# - generated file | |||
cobertura: | |||
@cat $(GO_TEST_OUTPUT)/coverage.txt | \ | |||
grep -v zz_generated.deepcopy | \ | |||
grep -v zz_ | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, should we reflect to tf-template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//go:generate find ../internal/controller -type d -empty -delete | ||
|
||
// NOTE(muvaf): Some of Terraform AWS provider files have "!generate" build tag | ||
// that prevent us from using it for generator program. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cause any problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just that we can't use generate
build tag like we do in other generation tools we have here.
config/provider.go
Outdated
r.ShortGroup = "ec2" | ||
case r.ShortGroup == "vpc": | ||
r.ShortGroup = "ec2" | ||
case name == "aws_lb_": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case name == "aws_lb_": | |
case strings.HasPrefix(name, "aws_lb"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a map with regexes and it covers both.
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Description of your changes
Updates all configs to match the new interfaces and updates Terrajet. There are a few small things like running Terrajet from
go:generate
that I'll open PRs in providertf-template.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually.