Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add doc for adding new resources #123

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Add doc for adding new resources #123

merged 6 commits into from
Oct 21, 2021

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Oct 19, 2021

Description of your changes

Resolves #118

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

N/A

docs/custom-configuration.md Outdated Show resolved Hide resolved
@turkenh turkenh marked this pull request as ready for review October 19, 2021 21:11
@luebken
Copy link
Collaborator

luebken commented Oct 21, 2021

@turkenh Do mind moving the contribution guide into a separate file? This would unclutter the landing page.

Edit: Move most of the content to custom-configuration.md and just have one link in the main readme?

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh ! I believe we'll be able to move that guide to Terrajet once the pipeline abstraction is in place, right? since it'll hide away most of provider-specific stuff in generator/main.go flow.

@turkenh
Copy link
Collaborator Author

turkenh commented Oct 21, 2021

@turkenh Do mind moving the contribution guide into a separate file? This would unclutter the landing page.

@luebken yeah good idea, will do.

@turkenh
Copy link
Collaborator Author

turkenh commented Oct 21, 2021

Thanks @turkenh ! I believe we'll be able to move that guide to Terrajet once the pipeline abstraction is in place, right? since it'll hide away most of provider-specific stuff in generator/main.go flow.

Yes, correct 👍

@turkenh turkenh merged commit 412cc96 into crossplane-contrib:main Oct 21, 2021
@turkenh turkenh deleted the how-to-contribute branch October 21, 2021 16:02
ulucinar added a commit to ulucinar/provider-jet-azure that referenced this pull request Oct 22, 2021
- Cherry-picked from crossplane-contrib/provider-jet-aws#123
  by @turkenh
- Extended the late-initialization section with an example use-case

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar added a commit to ulucinar/provider-jet-azure that referenced this pull request Oct 22, 2021
- Cherry-picked from crossplane-contrib/provider-jet-aws#123
  by @turkenh
- Extended the late-initialization section with an example use-case

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar added a commit to ulucinar/provider-jet-azure that referenced this pull request Oct 22, 2021
- Cherry-picked from crossplane-contrib/provider-jet-aws#123
  by @turkenh
- Extended the late-initialization section with an example use-case
- Adjustments specific to provider-tf-azure

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contributing section with steps on how to add a new resource
4 participants