Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix linter errors #107

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Fix linter errors #107

merged 3 commits into from
Oct 14, 2021

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Oct 14, 2021

Description of your changes

Tiny fix resolving linter error.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make reviewable

@turkenh turkenh changed the title Fix linter error Fix linter errors Oct 14, 2021
Signed-off-by: Hasan Turken <[email protected]>
@turkenh turkenh requested a review from ulucinar October 14, 2021 13:52
@turkenh
Copy link
Collaborator Author

turkenh commented Oct 14, 2021

I had to increase the linter timeout 2mins to 10mins since it was taking too long.
But it looks like it took much less after a successful run probably due to some sort of caching.

@ulucinar
Copy link
Collaborator

I think we will need to investigate/work on this linter issue. Why does it take too long / why when we retry it takes less time / does it store its progress between runs, etc.

@turkenh
Copy link
Collaborator Author

turkenh commented Oct 14, 2021

I think we will need to investigate/work on this linter issue. Why does it take too long / why when we retry it takes less time / does it store its progress between runs, etc.

Yeah definitely agree, opened this issue with some details to follow up on that. At this moment, I don't think it is urgent/critical.

@turkenh turkenh merged commit 654245c into crossplane-contrib:main Oct 14, 2021
@turkenh turkenh deleted the tiny-fix branch October 14, 2021 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants