-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCI charts #121
Conversation
e999a42
to
8e99ceb
Compare
5c4069f
to
f0ee1a5
Compare
Thanks a lot for this @goober, looking pretty good. I would like to do some testing while reviewing this. |
@turkenh Regarding the examples, do you want public hosted charts from an OCI registry that can be used or just an example url? |
Ideally yes. Isn't it possible to use dockerhub for this purpose? For example, can we push the same workpress helm chart to dockerhub (e.g. under your own account) and add it to the example? |
@turkenh Unfortunately it is not supported. See docker/roadmap#135 I have also updated the PR with support for insecure repositories and registries by adding the option |
Also upgraded kubebuilder after confirmation in the following slack thread |
c4a2707
to
d9b261a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks @goober!
Added two nitpicks.
@goober some checks are failing, any ideas? |
@turkenh I ran |
1f29a4f
to
82cd1c2
Compare
Signed-off-by: Mathias Åhsberg <[email protected]>
82cd1c2
to
ec820a1
Compare
Hey, I like this feature! Is there an example how to pull charts from a private OCI registry? In detail: How to configure the pull secrets for that? |
Description of your changes
This pull request aims to add support for pulling helm charts from OCI registries.
In addition, the pull request also adds support for pulling charts from insecure registries by adding the option
insecureSkipTLSVerify
to the Release manifestSince helm 3.8.0 needed some newer dependencies I decided to include a dependency upgrade in this PR as well. If it is preferable to have them as separate pull requests I can split them.
Open questions:
How should we handle insecure registries?Should we also add support for defining the url option withoci://
prefixed protocol? And if that is the case, should we require it to define the full tar file path? Or support the url to be defined asoci://localhost:5000/myrepo/mychart:2.7.0
Fixes #75
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Following manual tests have been performed:
repository
option set to aoci://
url and also tests with version option set and without version option set.url
option set to aoci://
url with and without:<tag>
suffix