Add Support for DNS Config on GKE #470
Conversation
Upgraded google.golang.org/api v0.52.0 to google.golang.org/api v0.97.0 sigs.k8s.io/controller-tools v0.8.0 to sigs.k8s.io/controller-tools v0.9.2 (fixes kubernetes-sigs/controller-tools#613 which occurs because google.golang.org/grpc is upgraded by the google.golang.org/api upgrade) The "DesiredAutopilot' field no longer exists in the newer version of the client. In the documentation, it says that converting between Standard and Autopilot is not supported: https://cloud.google.com/kubernetes-engine/docs/concepts/autopilot-overview#no_conversion Signed-off-by: Jensen Lo <[email protected]> Signed-off-by: Jensen Lo <[email protected]>
Signed-off-by: Jensen Lo <[email protected]> Signed-off-by: Jensen Lo <[email protected]>
Signed-off-by: Jensen Lo <[email protected]> Signed-off-by: Jensen Lo <[email protected]>
jensentanlo
force-pushed
the
add-DNS-config-to-gke
branch
from
f4f0190 to
010a6c9
Compare
|
@Feggah Thanks for the help yesterday with testing. Would it be possible to kick off the pre-merge checks for me? |
Feggah
left a comment
Feggah
left a comment
There was a problem hiding this comment.
Thanks for your effort, @jensentanlo !
Added some small coments in the code.
I think you also need to add the DNSConfig logic for the LateInitializeSpec method. This method is responsible for importing the field value when it isn't specified in the MR manifest. This is important when we are importing an existing GKE.
Lastly, I think you should change the TestLateInitializeSpec and TestIsUpToDate tests to cover the modifications you made in this PR.
Added relevant annotations Changed optional fields to pointers Added late initialization logic (and manually tested) Added more tests Signed-off-by: Jensen Lo <[email protected]>
|
Thanks for the detailed review comments, I think I've addressed everything + manually tested again as well. |
Feggah
left a comment
Feggah
left a comment
There was a problem hiding this comment.
Thanks, @jensentanlo! LGTM
2 participants
Description of your changes
In the GKE API and gcloud, there is the option to select CloudDNS instead of relying on the regular kube-dns. This adds those fields to the GKE Cluster CRD.
In order to do that, I had to upgrade some dependencies to deal with some issues as detailed here:
Upgraded google.golang.org/api v0.52.0 to google.golang.org/api v0.97.0
sigs.k8s.io/controller-tools v0.8.0 to sigs.k8s.io/controller-tools v0.9.2 (fixes kubernetes-sigs/controller-tools#613 which occurs because google.golang.org/grpc is upgraded by the google.golang.org/api upgrade)
The "DesiredAutopilot' field no longer exists in the newer version of the client. In the documentation, it says that converting between Standard and Autopilot is not supported: https://cloud.google.com/kubernetes-engine/docs/concepts/autopilot-overview#no_conversion
Fixes #464
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I created a GKE cluster and verified with gcloud that its dnsConfig was correctly set.