-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for all s3 canned-acls #891
Conversation
…trol,log-delivery-write canned-acl Signed-off-by: Raj Poluri <[email protected]>
@rpoluri do these two work? It seems like AWS ignores them?
|
if ACL grants contains |
@haarchri so we should merge as-is? I've tested it OK, except I didn't see any effect of the two mentioned. |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - i also checked it
@chlunde did we need to run git rebase & make generate again ? don't now how old the branch is
okay it is safe @rpoluri thanks for contribution |
…ns-checkout-digest Update actions/checkout digest to 8ade135
Added
aws-exec-read
bucket-owner-read
bucket-owner-full-control
log-delivery-write s3
canned-acls from supported list here https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html#canned-acl
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested