Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for all s3 canned-acls #891

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

rpoluri
Copy link

@rpoluri rpoluri commented Oct 26, 2021

Added
aws-exec-read
bucket-owner-read
bucket-owner-full-control
log-delivery-write s3
canned-acls from supported list here https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html#canned-acl

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

…trol,log-delivery-write canned-acl

Signed-off-by: Raj Poluri <[email protected]>
@chlunde
Copy link
Collaborator

chlunde commented Nov 25, 2021

@rpoluri do these two work? It seems like AWS ignores them?

bucket-owner-read | Object | Object owner gets FULL_CONTROL. Bucket owner gets READ access. If you specify this canned ACL when creating a bucket, Amazon S3 ignores it.
bucket-owner-full-control | Object | Both the object owner and the bucket owner get FULL_CONTROL over the object. If you specify this canned ACL when creating a bucket, Amazon S3 ignores it.

@chlunde chlunde self-requested a review November 25, 2021 18:05
@haarchri
Copy link
Member

haarchri commented Jan 6, 2022

if ACL grants contains bucket-owner-full-control only - it is default private acl

@chlunde
Copy link
Collaborator

chlunde commented Jan 6, 2022

@haarchri so we should merge as-is? I've tested it OK, except I didn't see any effect of the two mentioned.

@chlunde chlunde requested a review from haarchri January 6, 2022 11:00
@haarchri
Copy link
Member

haarchri commented Jan 6, 2022

Yes

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i also checked it
@chlunde did we need to run git rebase & make generate again ? don't now how old the branch is

@haarchri
Copy link
Member

haarchri commented Jan 6, 2022

okay it is safe

@rpoluri thanks for contribution

@haarchri haarchri merged commit 5c3ba97 into crossplane-contrib:master Jan 6, 2022
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…ns-checkout-digest

Update actions/checkout digest to 8ade135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants