Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): Fix LateInitialize & Slice diffs #2143

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(ecs): Fix LateInitialize & Slice diffs #2143

merged 1 commit into from
Jan 17, 2025

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Jan 17, 2025

Fixes:

  • Updating Volumes in TaskDefinitionFamily (LateInit)
  • Diffs on TaskDefinitionFamily/ECS Service

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Updating Environment on TaskDefinitionFamily and check if update loop occurs
  • Updating Volumes on TaskDefinitionFamily and check if update loop occurs

MisterMX
MisterMX approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @simwak!

@MisterMX MisterMX merged commit e4fd057 into crossplane-contrib:master Jan 17, 2025
8 of 9 checks passed
@github-actions GitHub Actions
Copy link

Successfully created backport PR #2144 for release-0.51.

@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
backport release-0.51
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simwak @MisterMX