Skip to content

chore: segregate internal logic to a package #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fernandezcuesta
Copy link

@fernandezcuesta fernandezcuesta commented Nov 13, 2024

The purpose here is to allow importing most of P&T logic into other functions, suck as function-environment-config (see discussion).
Per-se this should be a no-op.

Signed-off-by: Jesús Fernández <[email protected]>
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not inclined to approve this - it'd require the maintainers of this function to commit to supporting the P&T logic as a library. That's a different and larger commitment from supporting the function itself.

@fernandezcuesta
Copy link
Author

Yeah I understood this is not the correct approach right after reading the discussion on slack about crank in v2, where essentially a similar approach was discouraged.
Agree on that, closing.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants