Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call assume_init on Deferred's Data #779

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Don't call assume_init on Deferred's Data #779

merged 1 commit into from
Feb 5, 2022

Commits on Feb 5, 2022

  1. Don't call assume_init on Deferred's Data 

    In the crossbeam-deque test suite, a Deferred is created from a FnOnce
which is smaller than the Data. This makes the call to assume_init()
immediate UB (the reference to it created upon call is probably UB too).
Since Data doesn't have a Drop impl, we can just leave it in the MaybeUninit
wrapper.
    @saethlin
    saethlin committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b911157 View commit details
    Browse the repository at this point in the history