epoch: Fix UB in Pointable impl of [MaybeUninit<T>] #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeehoonkang Are there any changes that you'd like me to make? |
jeehoonkang
reviewed
May 27, 2021
crossbeam-epoch/src/atomic.rs
Outdated
| @@ -238,6 +238,7 @@ impl<T> Pointable for T { | |||
| // [`alloc::alloc::Layout::extend`] instead. | |||
| #[repr(C)] | |||
| struct Array<T> { | |||
| /// The number of elements (not the number of bytes). | |||
| size: usize, | |||
There was a problem hiding this comment.
@taiki-e maybe you also want to rename it to len?
|
@jeehoonkang Thanks for the review! I renamed bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
May 30, 2021
707: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-epoch 0.9.4 -> 0.9.5 - Fix UB in `Pointable` impl of `[MaybeUninit<T>]` (#694) - Support targets that do not have atomic CAS on stable Rust (#698) - Fix breakage with nightly feature due to rust-lang/rust#84510 (#692) - crossbeam-queue 0.3.1 -> 0.3.2 - Support targets that do not have atomic CAS on stable Rust (#698) - crossbeam-utils 0.8.4 -> 0.8.5 - Add `AtomicCell::fetch_update` (#704) - Support targets that do not have atomic CAS on stable Rust (#698) - crossbeam 0.8.0 -> 0.8.1 - Support targets that do not have atomic CAS on stable Rust (#698) Closes #702 Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693