Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change crossbeam-channel's license to MIT OR Apache-2.0 #537

Merged
1 commit merged into from
Jul 21, 2020
Merged

Change crossbeam-channel's license to MIT OR Apache-2.0 #537

1 commit merged into from
Jul 21, 2020

Conversation

nical
Copy link
Contributor

@nical nical commented Jul 16, 2020

Fixes #536

Was there breaking changes since the last published versions? it looks like it was 5 months ago so it sounds likely. If so I suspect you'll want to wait for other potential changes before making a 0.5 release, would it be possible to create a 0.4 branch and change publish the license update there on top of 0.4.2's revision?

That would allow me to use crossbeam-channel in WebRender.

@nical
Copy link
Contributor Author

nical commented Jul 20, 2020

The CI doesn't provide much information about the failing tests. They had been pending for a long long time so I suppose the backlog was just canceled/timed-out at some point.

ghost
ghost approved these changes Jul 21, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit 669736b into crossbeam-rs:master Jul 21, 2020
@ghost
Copy link

ghost commented Jul 21, 2020

Published a new patch version of crossbeam-channel that includes this PR.

@nical
Copy link
Contributor Author

nical commented Jul 21, 2020

Thanks a lot !

@taiki-e
Copy link
Member

taiki-e commented Sep 6, 2020 •
edited
Loading

Hm, the master branch was supposed to contain breaking changes... But does the compile seem to succeed?

Either way, I think we need to create the v0.7 branch and backport this and publish a new version of crossbeam-channel. (0.4.3 has UB (there is no UB in versions 0.4.2 or less), and adding default-feature is technically a breaking change)
(I did the same thing in crossbeam-queue before, but I pushed only the tag without pushing the branch; #523 (comment))

UPDATE: filed #557

@taiki-e taiki-e mentioned this pull request Sep 6, 2020
Merged
@taiki-e
Copy link
Member

taiki-e commented Sep 6, 2020

Published crossbeam-channel v0.4.4, and yanked crossbeam-channel v0.4.3.

@taiki-e taiki-e mentioned this pull request Sep 6, 2020
Merged
bors bot added a commit that referenced this pull request Sep 6, 2020
@bors @taiki-e
Merge #556 #558
a1b9bf3 
556: Improve docs for crossbeam-utils r=stjepang a=taiki-e

* Document some panics and errors
* Use intra-doc links
* Minor doc improvements

558: Update changelog r=taiki-e a=taiki-e

See #537 (comment) and #557 for the context.

The actual code for these releases is in the [`v0.7`](https://github.com/crossbeam-rs/crossbeam/tree/v0.7) branch.

Co-authored-by: Taiki Endo <[email protected]>
@taiki-e taiki-e mentioned this pull request Oct 9, 2020
Closed
@taiki-e taiki-e mentioned this pull request Nov 22, 2020
Merged
bors bot added a commit that referenced this pull request Nov 22, 2020
@bors @taiki-e
Merge #605
a01bb96 
605: Change crossbeam-queue's license to MIT OR Apache-2.0 r=taiki-e a=taiki-e

See #536 and #537 for more. `crossbeam-queue` has the same issue.

Co-authored-by: Taiki Endo <[email protected]>
@taiki-e taiki-e mentioned this pull request Nov 29, 2020
Merged
bcressey added a commit to bcressey/bottlerocket that referenced this pull request Sep 22, 2022
@bcressey
sources: clarify crossbeam license
b9f73af 
The BSD-2-Clause license is not listed upstream since this change:
  crossbeam-rs/crossbeam#537

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey mentioned this pull request Sep 22, 2022
Merged
bcressey added a commit to bcressey/bottlerocket-update-operator that referenced this pull request Sep 22, 2022
@bcressey
clarify crossbeam license
669c406 
The BSD-2-Clause license is not listed upstream since this change:
  crossbeam-rs/crossbeam#537

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey mentioned this pull request Sep 22, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
crossbeam-channel
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AND license in crossbeam_channel
2 participants
@nical @taiki-e