use image from main in test for cross dind test #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
approved these changes
Jul 8, 2022
Alexhuszagh
requested changes
Jul 8, 2022
Emilgardis
force-pushed
the
cross-image-release-fix
branch
from
c516f04
to
1bc6254
Compare
Alexhuszagh
approved these changes
Jul 8, 2022
|
You should probably use |
Emilgardis
force-pushed
the
cross-image-release-fix
branch
from
1bc6254
to
75b7354
Compare
|
switched to declare bors r=@Alexhuszagh |
bors bot
added a commit
that referenced
this pull request
Jul 8, 2022
924: use image from main in test for cross dind test r=Alexhuszagh a=Emilgardis Co-authored-by: Emil Gardström <[email protected]>
|
bors cancel shellcheck is not happy |
|
Canceled. |
Emilgardis
force-pushed
the
cross-image-release-fix
branch
2 times, most recently
from
018f166
to
ae82561
Compare
|
and switched back, don't see the reason for using declare (+ I used it wrong :) ) |
No worries as long as shellcheck passes and the code works. |
Emilgardis
force-pushed
the
cross-image-release-fix
branch
from
ae82561
to
60b44b8
Compare
|
bors r+ |
|
Build succeeded: |
Merged
Emilgardis
added a commit
to Emilgardis/cross
that referenced
this pull request
Jul 8, 2022
same as cross-rs#924
Emilgardis
added a commit
to Emilgardis/cross
that referenced
this pull request
Jul 8, 2022
same as cross-rs#924 also fixes no subs on variable passthrough
bors bot
added a commit
that referenced
this pull request
Jul 8, 2022
925: fix dind test r=Alexhuszagh a=Emilgardis same as #924 also fixes no subs on variable passthrough Co-authored-by: Emil Gardström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.