Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow verbose output in ct-ng images. #909

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Defaulting to verbose output pollutes the build logs during CI, which can be obscure any errors or status results. However, silencing output on local builds can make it difficult to debug issues. This checks for verbose output and the build script is running on a TTY, so we only get spinner output in those cases (IE, where the spinners actually work and are able to delete the current output line).

@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog) labels Jul 4, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner July 4, 2022 16:37
@Alexhuszagh Alexhuszagh marked this pull request as draft July 4, 2022 16:39
@Alexhuszagh Alexhuszagh marked this pull request as ready for review July 4, 2022 17:55
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Build succeeded:

@bors bors bot merged commit 5668896 into cross-rs:main Jul 4, 2022
@Emilgardis Emilgardis modified the milestone: v0.2.3 Jul 4, 2022
@Alexhuszagh Alexhuszagh deleted the build_verbose branch July 5, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants