Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wiki check toml #907

Merged
merged 1 commit into from
Jul 3, 2022
Merged

wiki check toml #907

merged 1 commit into from
Jul 3, 2022

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Jul 3, 2022 •
edited
Loading

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner July 3, 2022 20:12
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jul 3, 2022
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jul 3, 2022 •
edited
Loading

This TOML check is currently failing on snippets like:

[target.$TARGET]
image = "$REPO/$TARGET:$TAG"

To be fair, this isn't valid TOML, so should handle it like cross_toml.md for how we handle variables? Like target.TARGET?

Other than that, looks good.

@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 3, 2022

Build succeeded:

@bors bors bot merged commit 0622baa into cross-rs:main Jul 3, 2022
@Emilgardis Emilgardis deleted the wiki-check-toml branch July 3, 2022 21:59
@Emilgardis Emilgardis modified the milestone: v0.2.3 Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh