Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for mounted paths for docker-in-docker. #898

Merged
merged 1 commit into from
Jul 2, 2022
Merged

Bug fix for mounted paths for docker-in-docker. #898

merged 1 commit into from
Jul 2, 2022

Conversation

Alexhuszagh
Copy link
Contributor

@Alexhuszagh Alexhuszagh commented Jul 1, 2022 •
edited
Loading

Closes #893.

@Alexhuszagh Alexhuszagh added the bug label Jul 1, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner July 1, 2022 23:41
@Emilgardis
Copy link
Member

Does this cover everything? I don't know how this works in containerd

Emilgardis
Emilgardis approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this works.

Thanks for finding it!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 2, 2022

Build succeeded:

@bors bors bot merged commit 00c1de2 into cross-rs:main Jul 2, 2022
@Alexhuszagh Alexhuszagh deleted the dind_mount branch July 2, 2022 13:07
@Emilgardis Emilgardis modified the milestone: v0.2.3 Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.

Problem with 0.2.2 and CROSS_DOCKER_IN_DOCKER
2 participants
@Alexhuszagh @Emilgardis