Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always run tests #879

Merged
merged 1 commit into from
Jun 29, 2022
Merged

always run tests #879

merged 1 commit into from
Jun 29, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner June 28, 2022 23:51
@Emilgardis
Copy link
Member Author

CodeCov did not expect the default branch to be named main, so the yml did not get picked up for flags. This intentionally touches the codecov.yml file so that it get's recognized, but also makes it so that tests are always run, even on main, so that the project doesn't only get tested in staging, but on merge as well (so that coverage get's recorded on the main branch and not just in staging).

There could be a way to use the same artifacts as the sucessfull staging build did and just upload them, but I'm not sure how to do that without going with something like S3 or artifactory (there's no official api to download "any" artifact except for current workflow artifacts)

@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jun 28, 2022
@Emilgardis
Copy link
Member Author

There is also an argument to this that could be used.

When we upload the artifacts, we've already signaled to bors that the run was successfull and to merge, we could possibly set the --branch to main on staging builds

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jun 29, 2022

Is there a particular reason why this wasn't done before, potentially CI times? Because other than that, it seems like only a positive.

Copy link
Contributor

@Alexhuszagh Alexhuszagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was introduced in d1959de, so it seems that's just how it was always done. Should make the rest of the CI config logic for if/then tests easier as well. Since the tests are never that long, looks like an improvement in every case.

@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit 874eddd into cross-rs:main Jun 29, 2022
@Emilgardis Emilgardis deleted the fix-cov branch June 29, 2022 20:46
@Emilgardis Emilgardis added this to the v0.2.3 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants