Update Qemu version to v6.1.0 if possible. #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this looks good, and passes the tests, please don't merge it (yet) since I still have to update the README. |
|
There's so many compatible targets it makes no sense to do a partial test. bors try |
|
Failed due to an unrelated error (TLS handshake timeout while fetching from the registry), but all the MUSL images and a few others seem to work, which means it should work for everything. |
Emilgardis
reviewed
Jun 16, 2022
Emilgardis
approved these changes
Jun 16, 2022
|
r=me when readme updated, feel free to steal the ci and use it to parallel build and grab the versions to make sure it's correct, we should maybe even do that unconditionally for no other reason than curiosity now that we have a great way to do it |
tryBuild failed: |
The latest Qemu release contains numerous bug fixes, and other improvements, and the existing patches various issues reported in older Qemu versions. The only changes required are incrementing the Qemu version and adding ninja-build as a temporary dependency, since Qemu now uses it for the build system. However, Ubuntu 16.04, the base image for numerous dependencies we use, still ships with Python3.5, and Qemu 6.1.0 requires Python3.6+, as well as the ninja-build system. We therefore add a check to see if we have a compatible Python version, and if we do, build the last Qemu version, so our code can be fully backwards-compatible. Fixes cross-rs#557. Closes cross-rs#587.
Alexhuszagh
force-pushed
the
qemu_rolling
branch
from
f00faeb to
ca03a50
Compare
Alexhuszagh
force-pushed
the
qemu_rolling
branch
from
ca03a50 to
e36cdaf
Compare
|
bors r=Emilgardis |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Qemu release contains numerous bug fixes, and other improvements, and the existing patches various issues reported in older Qemu versions. The only changes required are incrementing the Qemu version and adding ninja-build as a temporary dependency, since Qemu now uses it for the build system. However, Ubuntu 16.04, the base image for numerous dependencies we use, still ships with Python3.5, and Qemu 6.1.0 requires Python3.6+, as well as the ninja-build system. We therefore add a check to see if we have a compatible Python version, and if we do, build the last Qemu version, so our code can be fully backwards-compatible.
Closes #587.