more features for build-docker-image
#791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
Emilgardis
commented
Jun 14, 2022
Emilgardis
force-pushed
the
more-build-opts
branch
2 times, most recently
from
ac498d6
to
c01a083
Compare
|
bors try- bors try |
tryBuild failed: |
|
oh yeah, since we run this ci on a different branch, the annotations won't show up here :/ might have to use gh api for that |
|
maybe add a run for if a specific dockerfile is changed that is run on the pr branch |
Emilgardis
force-pushed
the
more-build-opts
branch
from
c01a083
to
ad264d8
Compare
Alexhuszagh
reviewed
Jun 14, 2022
Emilgardis
commented
Jun 14, 2022
Emilgardis
force-pushed
the
more-build-opts
branch
from
8908434
to
759d4f0
Compare
Emilgardis
commented
Jun 14, 2022
Alexhuszagh
reviewed
Jun 14, 2022
Alexhuszagh
reviewed
Jun 14, 2022
you can now specify * tag `--tag` * repository `--repository` * disable caching `--no-cache` * do a dry run `--dry-run` * disable fastfail `--no-fastfail` * run every target that exists in current CI `--from-ci` this also makes it so that if running `build-docker-image` on github actions, a summary will be shown signaling success or failure for the target(s)
Emilgardis
force-pushed
the
more-build-opts
branch
from
759d4f0
to
37c379b
Compare
Alexhuszagh
approved these changes
Jun 14, 2022
|
I'm fine with it as-is, or if you remove the warning mentioned above. Feel free to |
I've made it so it's only shown in multi target builds, which we have none of right now. |
|
bors r+ |
|
Build succeeded: |
Alexhuszagh
added
meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can now specify
--tag--repository--no-cache--dry-run--no-fastfail--from-cithis also makes it so that if running
build-docker-imageon github actions with multiple targets,a summary will be shown signaling success or failure for the target(s)