Add utility to install git hooks. #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably should have a powershell script for Windows, IMO, rather than bash. |
Alexhuszagh
commented
Jun 13, 2022
cross-dev/pre-commit
Outdated
|
|
||
| cargo fmt -- --check | ||
| cargo clippy --all-features -- --deny warnings | ||
| if cargo +nightly >/dev/null 2>&1; then |
There was a problem hiding this comment.
Changed this to silently check of the nightly channel is installed, and only run the clippy check if it is.
Emilgardis
reviewed
Jun 13, 2022
Adds the `install-git-hooks` to `xtask`, which installs pre-commit hooks to ensure clippy and fmt are run on all commits.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
install-git-hookstocross-dev, which installs pre-commit hooks to ensure clippy and fmt are run on all commits.