-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-std config option. #782
Conversation
what if we want to build std with our compiler options even if std is already provided? |
Would it be a good idea then to make it always active when set to true? So remove the following checks and only allow it to be enabled on nightly in all cases? I'll have to confirm how it works for targets with pre-built standard libraries, if it still needs nightly to compile std from source. |
you need nightly, and that's probably always going to be true due to some features std uses. (unless you use |
Detects if `rust-std` is not an available component for a target, and if `build-std = true` in `Cross.toml` under `[build]` or `[target.(...)]`, then use the `-Zbuild-std` flag. This has higher priority than `xargo`: `xargo` will only be used if a target is not a built-in. A sample `Cross.toml` file is the following: ```toml [target.x86_64-unknown-dragonfly] build-std = true ``` Closes cross-rs#692.
I've updated it so |
lgtm, please edit the pr description (as that's what bors uses for commit message) |
bors r=Emilgardis |
Build succeeded: |
Detects if
rust-std
is not an available component for a target, and ifbuild-std = true
inCross.toml
under[build]
or[target.(...)]
, then use the-Zbuild-std
flag.Closes #692.