Forward Cargo exit code #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
approved these changes
Jun 9, 2022
|
bors r+ (This might actually fail due to unrelated issues, but this would be due to secretly failing unittests that we currently think are passing: or, this PR is a really good thing). |
bors bot
added a commit
that referenced
this pull request
Jun 9, 2022
775: Forward Cargo exit code r=Alexhuszagh a=Jules-Bertholet Forward Cargo's exit code. For example, if `cargo test` returns a non-zero exit code due to a failing test, `cross` will also return a non-zero exit code. Co-authored-by: Jules Bertholet <[email protected]>
|
Build failed: |
|
@Emilgardis Can you merge this manually? Only failing test is |
|
we have xargo for a reason, making it use nightly would fix it, no? |
Yes it should. Let me test locally first. |
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 9, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. Necessary to merge cross-rs#775.
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 9, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. Necessary to merge cross-rs#775.
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 9, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. Necessary to merge cross-rs#775.
bors bot
added a commit
that referenced
this pull request
Jun 9, 2022
775: Forward Cargo exit code r=Emilgardis a=Jules-Bertholet Forward Cargo's exit code. For example, if `cargo test` returns a non-zero exit code due to a failing test, `cross` will also return a non-zero exit code. 776: Bug fix for dragonfly and CI tests. r=Emilgardis a=Alexhuszagh Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. Necessary to merge #775. Co-authored-by: Jules Bertholet <[email protected]> Co-authored-by: Alex Huszagh <[email protected]>
|
bors r- |
|
Canceled. |
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 10, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. This also adds `build-std` detection into Rust, so we don't have to provide it manually. It allows use to avoid using `xargo` when possible. Necessary to merge cross-rs#775. Closes cross-rs#692.
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 10, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. This also adds `build-std` detection into Rust, so we don't have to provide it manually. It allows use to avoid using `xargo` when possible. Necessary to merge cross-rs#775. Closes cross-rs#692.
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 10, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. This also adds `build-std` detection into Rust, so we don't have to provide it manually. It allows use to avoid using `xargo` when possible. Necessary to merge cross-rs#775.
bors bot
added a commit
that referenced
this pull request
Jun 10, 2022
776: Bug fix for dragonfly and CI tests. r=Emilgardis a=Alexhuszagh Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. Necessary to merge #775. Co-authored-by: Alex Huszagh <[email protected]>
Emilgardis
approved these changes
Jun 10, 2022
|
Build succeeded: |
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 10, 2022
Added `build-std` flag to CI, so for targets that support `std` but are tier 3 targets, we can use the experimental `build-std` support to ensure they build. Also patches linking on dragonfly to ensure we use `libgcc_s` instead of `libgcc_pic`, which no longer exists. We just create a symlink for that purpose. This also adds `build-std` detection into Rust, so we don't have to provide it manually. It allows use to avoid using `xargo` when possible. Necessary to merge cross-rs#775.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward Cargo's exit code. For example, if
cargo testreturns a non-zero exit code due to a failing test,crosswill also return a non-zero exit code.