freebsd: Add libprocstat.so #582
Conversation
|
I have no idea why this fails to build. |
|
Its unrelated, probably nix-rust/nix#1491 Need to bump nix version |
|
bors try |
tryBuild succeeded: |
|
So bors says it works but the CI still fails? |
|
We merged a fix for the CI in #583, but github actions doesn't run on the (would be) merge commit, it runs on the prs ref. I don't really feel comfortable merging this as I'm not familiar with FreeBSD. But it doesn't seem like it'd be bad to have. EDIT: A changelog entry is missing also. Could you add one? |
If we don't add this library, we'll eventually run into linking problems due to libprocstat.so not being found.
|
@reitermarkus r=me if you think this is ok, i suspect it is |
|
Rebased and added CHANGELOG entry.
Since this really just adds a library I think the possible bad impact is fairly limited. Without this, my fairly boring Rust program didn't compile and with it, it does. :) |
|
Thank you for taking care of cross. I think cross fills an important role in the Rust ecosystem and it needs love. :) |
|
Any chance for a good ol' mergerino? |
|
ill merge it, don't see that should be an issue. Thank you! bors r+ |
582: freebsd: Add libprocstat.so r=Emilgardis a=svenstaro If we don't add this library, we'll eventually run into linking problems due to libprocstat.so not being found. Co-authored-by: Sven-Hendrik Haase <[email protected]>
|
Build failed:
|
|
Huh how did this fail? |
|
404, could be temporary or it needs to be changed |
|
It needs to be updated to https://pkg.freebsd.org/FreeBSD:12:i386/quarterly/All/openssl-1.1.1l,1.txz. I'm submitting another PR I guess. |
|
Alright @Emilgardis I posted a fix as #588. |
|
bors r+ |
|
Build succeeded:
|
This is fine now that cross-rs/cross#582 is merged.
If we don't add this library, we'll eventually run into linking problems due to libprocstat.so not being found.