Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro builds: Deterministically iterate through docker/ folder #573

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Jul 22, 2021

One of the Arch Linux rebuilders has trouble reproducing the cross binary we distribute in Arch Linux. We assume this is because it runs a different filesystem than the official build server, causing fs::read_dir to yield the directory content in a different order.

This patch explicitly sorts the directory content of docker/ in build.rs before constructing a list that gets embedded in the binary.

Full writeup can be found over here: https://twitter.com/sn0int/status/1418254640324521997

@kpcyrd kpcyrd requested review from Dylan-DPC-zz and a team as code owners July 22, 2021 16:15
@adamgreig
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jul 25, 2021
@bors
Copy link
Contributor

bors bot commented Jul 25, 2021

try

Build succeeded:

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and nice write-up too!

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 25, 2021

Build succeeded:

@bors bors bot merged commit dc2e724 into cross-rs:master Jul 25, 2021
@kpcyrd
Copy link
Contributor Author

kpcyrd commented Jul 25, 2021

Thanks! Are there any plans for a new release? I've noticed there hasn't been one since about a year. :)

@kpcyrd kpcyrd deleted the repro-read-dir branch July 25, 2021 19:22
@adamgreig
Copy link
Member

Yea, we'd like a new release (#542) but currently have a couple last blockers (and should ideally get a few more pending PRs merged...). The main issue is we're desperately low on maintainer time, since most of the rust-embedded team nominally responsible don't use cross or know much about it. I've just posted #574 with details of that.

@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog) labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants