Repro builds: Deterministically iterate through docker/ folder #573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the Arch Linux rebuilders has trouble reproducing the cross binary we distribute in Arch Linux. We assume this is because it runs a different filesystem than the official build server, causing
fs::read_dir
to yield the directory content in a different order.This patch explicitly sorts the directory content of docker/ in build.rs before constructing a list that gets embedded in the binary.
Full writeup can be found over here: https://twitter.com/sn0int/status/1418254640324521997