-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update changelog for pending release #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not solve #542, but it touches on it. |
This looks great! What is required to get this merged and the latest version released? Thank you |
lpil
previously approved these changes
Jun 15, 2021
adamgreig
requested changes
Jun 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for putting this together! I spotted one typo which I'll fix then good to merge.
adamgreig
approved these changes
Jun 20, 2021
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 20, 2021
559: fix: update changelog for pending release r=adamgreig a=rawkode Changelog update cc #542 Co-authored-by: David McKay <[email protected]> Co-authored-by: Adam Greig <[email protected]>
Timed out. |
bors merge 🤞 |
Build succeeded: |
svenstaro
pushed a commit
to svenstaro/cross
that referenced
this pull request
Aug 29, 2021
559: fix: update changelog for pending release r=adamgreig a=rawkode Changelog update cc cross-rs#542 Co-authored-by: David McKay <[email protected]> Co-authored-by: Adam Greig <[email protected]>
Alexhuszagh
added
the
no-ci-targets
PRs that do not affect any cross-compilation targets.
label
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog update
cc #542