specify the minimal profile when installing rust toolchain (due to bug in rustup?)

[blesson3]

this is needed bc of some bug(?) in rustup not being able to install the necessary toolchain without error using the default profile, so the minimal profile is needed.

see my comment in the rustup project regarding this issue: rust-lang/rustup#2661 (comment)

this is the error I get when running cross

# clear all toolchains
$ rm -rf ~/.rustup                                       

$ cross build --target aarch64-unknown-linux-gnu
warning: toolchain 'nightly-x86_64-unknown-linux-gnu' may not be able to run on this system.
warning: If you meant to build software to target that platform, perhaps try `rustup target add x86_64-unknown-linux-gnu` instead?
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2021-02-22, rust version 1.52.0-nightly (3e826bb11 2021-02-21)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
 15.0 MiB /  15.0 MiB (100 %)  10.0 MiB/s in  1s ETA:  0s
info: downloading component 'rust-std'
 24.9 MiB /  24.9 MiB (100 %)  12.7 MiB/s in  2s ETA:  0s
info: downloading component 'rustc'
 47.9 MiB /  47.9 MiB (100 %)  13.5 MiB/s in  3s ETA:  0s
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: using up to 500.0 MiB of RAM to unpack components
info: installing component 'clippy'
info: installing component 'rust-docs'
 15.0 MiB /  15.0 MiB (100 %)   6.0 MiB/s in  2s ETA:  0s
info: rolling back changes
error: failed to install component: 'rust-docs-x86_64-unknown-linux-gnu', detected conflict: '"share/doc/rust/html/std/keyword.self.html"'
error: couldn't install toolchain `nightly-x86_64-unknown-linux-gnu`
caused by: `"rustup" "toolchain" "add" "nightly-x86_64-unknown-linux-gnu"` failed with exit code: Some(1)
note: run with `RUST_BACKTRACE=1` for a backtrace

I get the same error when running cross with the following (randomly selected toolchains)

• aarch64-unknown-linux-gnu
• armv7-linux-androideabi
• thumbv6m-none-eabi
• s390x-unknown-linux-gnu

cargo test seems to pass and cross-compilation seems to work okay now (with this PR).

Another work-around that isn't this pull request

install the toolchain outside of cross using the `minimal` profile, then run cross command

$ rm -rf ~/.rustup

$ rustup toolchain add nightly-x86_64-unknown-linux-gnu --profile minimal
warning: toolchain 'nightly-x86_64-unknown-linux-gnu' may not be able to run on this system.
warning: If you meant to build software to target that platform, perhaps try `rustup target add x86_64-unknown-linux-gnu` instead?
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2021-02-22, rust version 1.52.0-nightly (3e826bb11 2021-02-21)
info: downloading component 'cargo'
info: downloading component 'rust-std'
 24.9 MiB /  24.9 MiB (100 %)  12.4 MiB/s in  2s ETA:  0s
info: downloading component 'rustc'
 47.9 MiB /  47.9 MiB (100 %)  13.6 MiB/s in  3s ETA:  0s
info: installing component 'cargo'
info: using up to 500.0 MiB of RAM to unpack components
info: installing component 'rust-std'
 24.9 MiB /  24.9 MiB (100 %)  11.1 MiB/s in  2s ETA:  0s
info: installing component 'rustc'
 47.9 MiB /  47.9 MiB (100 %)  12.6 MiB/s in  3s ETA:  0s

  nightly-x86_64-unknown-linux-gnu installed - (error reading rustc version)

info: default toolchain set to 'nightly-x86_64-unknown-linux-gnu'
info: checking for self-updates

$ cross build --target aarch64-unknown-linux-gnu                         
info: downloading component 'rust-std' for 'aarch64-unknown-linux-gnu'
info: installing component 'rust-std' for 'aarch64-unknown-linux-gnu'
info: using up to 500.0 MiB of RAM to unpack components
 26.6 MiB /  26.6 MiB (100 %)  11.5 MiB/s in  2s ETA:  0s
   Compiling libc v0.2.77
   Compiling proc-macro2 v1.0.21
   Compiling syn v1.0.41
...

[blesson3]

I definitely understand if the right solution here is updated documentation (instead of a code-change). I figured I would post the PR anyway in-case this is what was preferred.

[UebelAndre]

This seems strictly better since it would result in less data being downloaded. @Dylan-DPC Would you be able to take a look?

[reitermarkus]

bors try

[bors]

try

Build failed:

• rust-embedded.cross

[blesson3]

Looks like the only target that failed was `x86_64-unknown-netbsd`. Seems like the cause was a request 404 to `https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/lang/gcc5/patches/patch-libstdc++-v3_config_os_bsd_netbsd_ctype__base.h`. I don’t believe my change would have caused this issue, let me know if you want me to look into this further. (I’m on mobile so formatting might be bad)

…

-- Matt Blessed

On May 2, 2021, at 12:21 PM, bors[bot] ***@***.***> wrote:  try Build failed: rust-embedded.cross — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[reitermarkus]

bors retry

[bors]

try

Build succeeded:

• shellcheck
• rust-embedded.cross

[Emilgardis]

LGTM, thank you!

[Emilgardis]

bors r+

[bors]

Build succeeded:

• rust-embedded.cross
• shellcheck