Build docker images in separate step. #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
ci-config
branch
from
3de3737
to
adf100d
Compare
|
bors try |
tryBuild failed
|
reitermarkus
force-pushed
the
ci-config
branch
from
c8291fb
to
f1296ab
Compare
|
bors retry |
tryBuild failed
|
reitermarkus
force-pushed
the
ci-config
branch
from
dfcf563
to
a18f558
Compare
|
bors try |
tryBuild failed
|
|
bors try |
tryBuild failed
|
|
bors retry |
tryBuild succeeded
|
|
bors try |
tryBuild failed
|
The recommendation given in the README to use `dpkg --add-architecture` to install additional libraries doesn't actually work because the packages for most architectures are on a different server. This change configures the APT sources so it knows where every architecture is located, and the recommendation given in the README works. The package locations should be accurate for all current Ubuntu releases, although I have only tested it with 16.04 and just looked at the repository content for later versions. I have tested these two shell commands in a docker image based on the official cross docker images. I think this would be the best place to put them so that all cross users can benefit from them, and they *should* work here but I've not tried to build an image.
|
bors try |
tryBuild failed
|
reitermarkus
force-pushed
the
ci-config
branch
2 times, most recently
from
9109276
to
88e69a0
Compare
reitermarkus
force-pushed
the
ci-config
branch
from
88e69a0
to
353e93d
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2020
366: Build docker images in separate step. r=therealprof a=reitermarkus Also, increase timeout for the build step. Co-authored-by: Markus Reiter <[email protected]> Co-authored-by: rvolgers <[email protected]>
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2020
366: Build docker images in separate step. r=reitermarkus a=reitermarkus Also, increase timeout for the build step. Co-authored-by: Markus Reiter <[email protected]> Co-authored-by: rvolgers <[email protected]>
Build succeeded
|
theunkn0wn1
added a commit
to theunkn0wn1/cross
that referenced
this pull request
Aug 20, 2020
theunkn0wn1
added a commit
to theunkn0wn1/cross
that referenced
this pull request
Aug 20, 2020
…ross-rs#366 - as it relates to `dpkg --add-architecture`
theunkn0wn1
added a commit
to theunkn0wn1/cross
that referenced
this pull request
Sep 8, 2020
…ross-rs#366 - as it relates to `dpkg --add-architecture`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, increase timeout for the build step.