Fix Android’s CPU features #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android target uses CPU features such as +popcnt and +sse4.2 which are not available on Penryn. List the used CPU exactly the same way as it is listed in the Rust target.
therealprof
previously approved these changes
Oct 26, 2019
bors bot
added a commit
that referenced
this pull request
Oct 26, 2019
339: Fix Android’s CPU features r=therealprof a=nagisa The Rust Android target uses CPU features such as +popcnt and +sse4.2 which are not available on Penryn. List the used CPU exactly the same way as it is listed in the Rust target [here](https://github.com/rust-lang/rust/blob/master/src/librustc_target/spec/x86_64_linux_android.rs#L7). Please publish an updated docker image sooner rather than later. Co-authored-by: Simonas Kazlauskas <[email protected]>
|
Tests failing |
powerpc and sparc build failures? Looks totally unrelated. |
Build failed
|
|
PowerPC and Sparc usually need the kernel version to be updated. |
reitermarkus
approved these changes
Oct 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 27, 2019
339: Fix Android’s CPU features r=reitermarkus a=nagisa The Rust Android target uses CPU features such as +popcnt and +sse4.2 which are not available on Penryn. List the used CPU exactly the same way as it is listed in the Rust target [here](https://github.com/rust-lang/rust/blob/master/src/librustc_target/spec/x86_64_linux_android.rs#L7). Please publish an updated docker image sooner rather than later. Co-authored-by: Simonas Kazlauskas <[email protected]>
Build succeeded
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust Android target uses CPU features such as +popcnt and +sse4.2 which
are not available on Penryn. List the used CPU exactly the same way as
it is listed in the Rust target here.
Please publish an updated docker image sooner rather than later.