Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.15 #302

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Release 0.1.15 #302

merged 1 commit into from
Sep 6, 2019

Conversation

reitermarkus
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @jamesmunns

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2019
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote nits...

@malbarbo
Copy link
Contributor

malbarbo commented Sep 4, 2019

@reitermarkus When the qemu-system supporting was added in #153 and #166 no documentation was provided... It would be great if some documentation could be added before a new release (I can't write it myself now, but maybe someone can).

By the way, thanks for moving the project forward, you are doing a great work!

@reitermarkus
Copy link
Member Author

Actually I'd rather prefer the good old fashioned ASCII quotes...

I think typographic quotes should be preferred for prose.

I can't write it myself now

I'm not using the cross run functionality myself so I can't either. And I don't think this should be blocking a new release, which is long overdue. Would be great if you could do it if you have time in the future.

@Dylan-DPC-zz
Copy link

When the qemu-system supporting was added in #153 and #166 no documentation was provided..

@malbarbo Yep sorry about that. The prs were dragging on for too long so didn't want to drag it further

@reitermarkus
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 5, 2019

👎 Rejected by code reviews

@therealprof
Copy link
Contributor

Actually I'd rather prefer the good old fashioned ASCII quotes...

I think typographic quotes should be preferred for prose.

These are english text files, often processed on the command line. Typographic quotes are a dime a dozen and will cause random problems for people working with those documents. Until there's a very good reason to deviate I'd rather we stick to plain ASCII.

@reitermarkus
Copy link
Member Author

These are english text files

And that's exactly the reason why we should use quotes appropriate for English text.

This is a Markdown file, there is no good reason why this file would ever be processed by a tool which doesn't support UTF-8 or HTML escape codes.

@Dylan-DPC-zz
Copy link

Let's not waste time bike-shedding such small things, it's a release note, we can always modify it later

@Dylan-DPC-zz Dylan-DPC-zz dismissed therealprof’s stale review September 6, 2019 07:23

Let's not waste time bike-shedding such small things, it's a release note, we can always modify it later

@Dylan-DPC-zz
Copy link

bors: r+

bors bot added a commit that referenced this pull request Sep 6, 2019
302: Release 0.1.15 r=Dylan-DPC a=reitermarkus



Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 6, 2019

Build succeeded

  • rust-embedded.cross

@bors bors bot merged commit 180e344 into cross-rs:master Sep 6, 2019
@therealprof
Copy link
Contributor

Let's not waste time bike-shedding such small things, it's a release note, we can always modify it later

No, we cannot. If it's released it will part of the release. Apart from that the point is not to include a change that was not there but to NOT make an incorrect change.

@therealprof
Copy link
Contributor

@Dylan-DPC Also I'd appreciate if you did not simply dismiss a members concern.

@reitermarkus reitermarkus deleted the release-0.1.15 branch September 17, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants