Add support for clippy. #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
requested review from
Dylan-DPC-zz,
jamesmunns and
a team
as code owners
|
bors: try |
tryBuild failed |
|
The test failures look unrelated. |
|
bors: try |
|
This is also blocked on rust-lang/rust#57426. |
tryBuild failed |
|
This should be working now with the new nightly. |
|
hopefully bors: try |
tryBuild succeeded |
Dylan-DPC-zz
approved these changes
Jan 9, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jan 9, 2019
246: Add support for clippy. r=Dylan-DPC a=reitermarkus Automatically install `clippy` for the appropriate toolchain. Also fixes `rust-src` not being installed for the appropriate toolchain on macOS. Co-authored-by: Markus Reiter <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically install
clippyfor the appropriate toolchain. Also fixesrust-srcnot being installed for the appropriate toolchain on macOS.