Add arm-linux-gnueabihf.
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
requested review from
Dylan-DPC-zz,
jamesmunns and
a team
as code owners
|
@Dylan-DPC, ping. 😉 |
|
bors: try |
tryBuild failed |
|
The test failure definitely is an issue with the latest nightly or a network issue, since it ran successfully a few days ago on Travis for my fork. Not sure what I can do here. |
|
@reitermarkus Thanks. Yeh looking at the failures on both PRs, i know it isn't related to them but we got to resolve the issues in order to merge this. |
|
Seems like this is the cause: rust-lang/rust#57426 |
|
Thanks. Will retry this once that is merged. |
|
This should now also work. |
|
bors: try |
tryBuild failed |
|
The test failure seems to be a temporary network issue. |
|
bors retry |
tryBuild succeeded |
|
Anything else that needs to be done here? |
Dylan-DPC-zz
approved these changes
Jan 10, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jan 10, 2019
245: Add `arm-linux-gnueabihf`. r=Dylan-DPC a=reitermarkus I took the suggestion from #158 (comment) and used a pre-compiled toolchain. There are two commits here, the first one uses https://github.com/raspberrypi/tools, in the second one I switched to https://toolchains.bootlin.com/releases_armv6-eabihf.html. I am not sure however if the `sysroot` is set correctly, since everything except `qemu` also works without `LD_LIBRARY_PATH=/usr/arm-linux-gnueabihf/lib:/usr/arm-linux-gnueabihf/arm-buildroot-linux-gnueabihf/lib`. Co-authored-by: Markus Reiter <[email protected]>
Build failed |
|
Nightly builds failing since nightly is broken. Will r+ this tomorrow 👍 |
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2019
245: Add `arm-linux-gnueabihf`. r=Dylan-DPC a=reitermarkus I took the suggestion from #158 (comment) and used a pre-compiled toolchain. There are two commits here, the first one uses https://github.com/raspberrypi/tools, in the second one I switched to https://toolchains.bootlin.com/releases_armv6-eabihf.html. I am not sure however if the `sysroot` is set correctly, since everything except `qemu` also works without `LD_LIBRARY_PATH=/usr/arm-linux-gnueabihf/lib:/usr/arm-linux-gnueabihf/arm-buildroot-linux-gnueabihf/lib`. Co-authored-by: Markus Reiter <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the suggestion from #158 (comment) and used a pre-compiled toolchain.
There are two commits here, the first one uses https://github.com/raspberrypi/tools, in the second one I switched to https://toolchains.bootlin.com/releases_armv6-eabihf.html.
I am not sure however if the
sysrootis set correctly, since everything exceptqemualso works withoutLD_LIBRARY_PATH=/usr/arm-linux-gnueabihf/lib:/usr/arm-linux-gnueabihf/arm-buildroot-linux-gnueabihf/lib.