Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require dockerfile to be specified relative to cargo workspace root #1574

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

ziutech
Copy link
Contributor

@ziutech ziutech commented Oct 15, 2024

The docs say that the dockerfile should be specified relative to Cargo.toml, but actually it is specified relative to current working directory. This is confusing.

This PR makes it so that dockerfiles are always relative to workspace root.

@ziutech ziutech requested a review from a team as a code owner October 15, 2024 07:21
@Emilgardis
Copy link
Member

Thanks for spotting this! This was definitely a mistake. Could you add a changelog entry as such

add a file 1574.json in .changes/

{
    "type": "fixed",
    "description": "`dockerfile` path is relative to cargo workspace root",
}

@ziutech
Copy link
Contributor Author

ziutech commented Oct 15, 2024

I was thinking whether this should be marked as a "change", because this might break someone's setup, but "fix" is probably correct.

@Emilgardis Emilgardis merged commit 4090bec into cross-rs:main Oct 15, 2024
20 of 21 checks passed
@ziutech
Copy link
Contributor Author

ziutech commented Oct 15, 2024

Thanks!

@ziutech ziutech deleted the dockerfile-relative branch October 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants