Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using certain config values in Cargo.toml #1183

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

Emilgardis
Copy link
Member

pre-build = "file" and image.toolchain had a bad serialization, this fixes that

Closes #1182

`pre-build = "file"` and `image.toolchain` had a bad serialization
@Emilgardis Emilgardis requested a review from a team as a code owner January 6, 2023 02:55
@Emilgardis
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 6, 2023
1183: Fix error when using certain config values in Cargo.toml r=Emilgardis a=Emilgardis

`pre-build = "file"` and `image.toolchain` had a bad serialization, this fixes that

Closes #1182


Co-authored-by: Emil Gardström <[email protected]>
@Emilgardis
Copy link
Member Author

bors cancel

@bors
Copy link
Contributor

bors bot commented Jan 6, 2023

Canceled.

@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Jan 6, 2023
@Emilgardis
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 6, 2023

Build succeeded:

@bors bors bot merged commit 8c86a98 into cross-rs:main Jan 6, 2023
@Emilgardis Emilgardis deleted the fix-1182 branch January 6, 2023 18:38
@Emilgardis Emilgardis added this to the v0.2.5 milestone Feb 4, 2023
@Emilgardis Emilgardis mentioned this pull request Feb 4, 2023
bors bot added a commit that referenced this pull request Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Alex Huszagh <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
bors bot added a commit that referenced this pull request Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <[email protected]>
Co-authored-by: Alex Huszagh <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config in Cargo.toml: invalid type: map, expected a string for key target.x86_64-unknown-freebsd.image
1 participant