Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Linux kernel versions from 5.x to 6.x for certain targets. #1095

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Closes #1094.

@Alexhuszagh Alexhuszagh added bug container-images breaking change A-powerpc Area: PowerPC targets A-sparc Area: sparc targets A-riscv Area: riscv targets labels Oct 24, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner October 24, 2022 17:31
@Alexhuszagh
Copy link
Contributor Author

bors try --target sparc64-unknown-linux-gnu powerpc64-unknown-linux-gnu riscv64-unknown-linux-gnu

bors bot added a commit that referenced this pull request Oct 24, 2022
@Emilgardis
Copy link
Member

this changelog entry should probably be applied to #591 as well

@bors
Copy link
Contributor

bors bot commented Oct 24, 2022

try

Build succeeded:

@@ -0,0 +1,6 @@
{
"type": "fixed",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it so this used a fixed entry while the other uses a changed entry, so this makes it clear that this is a bug fix, and the other is a part of the image upgrade.

},
{
"type": "changed",
"description": "change powerpc64, riscv64, and sparc64 *-linux-gnu images to use a 6.x kernel instead of a 5.x kernel.",
Copy link
Member

@Emilgardis Emilgardis Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they went from 4* to 5* in this bump, no?

so shouldn't this be

change powerpc64, riscv64, and sparc64 *-linux-gnu images to use a 6.x kernel instead of a 4.x kernel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the changelog file should probably be renamed to 591-1095.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've consolidated the two and changed the changelog to be something like:

[
    {
        "type": "changed",
        "description": "upgraded most linux images to use a 5.x kernel instead of a 4.x kernel.",
        "breaking": true
    }
    {
        "type": "changed",
        "description": "updated powerpc64, riscv64, and sparc64 *-linux-gnu images to use a 6.x kernel instead of a 4.x kernel.",
        "breaking": true,
        "issues": [1094]
    }
]

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

If you really need kernel version 5 for these targets, consider using an older version of the image found on for example https://github.com/cross-rs/cross/pkgs/container/s390x-unknown-linux-gnu/versions

@bors
Copy link
Contributor

bors bot commented Oct 24, 2022

Build succeeded:

@bors bors bot merged commit 1792621 into cross-rs:main Oct 24, 2022
@Alexhuszagh Alexhuszagh deleted the linux_image_fix branch October 25, 2022 14:05
@Emilgardis Emilgardis added this to the v0.3.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-powerpc Area: PowerPC targets A-riscv Area: riscv targets A-sparc Area: sparc targets breaking change bug container-images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux Image Fails for Certain Targets Due to Migration from Kernel 5.x to 6.x
2 participants