Add D3DFMT_UNKNOWN checks on object creation #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I also ask to fix warnings of this kind while you're at it? Project stopped compiling with c++latest after recent merges. |
|
@ThirteenAG Sorry for the trouble, but it all works fine here in MSVC 2022 (I always compile and check, of course), so not sure what the problem is. P.S.: |
|
It's probably a warnings-as-errors thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D3D8 has some specific pointer clearing behavior around D3DFMT_UNKNOWN format validations. These fix several Wine tests, but also a test I wrote myself that passes on native D3D8.