Set the correct value of 0.0f for D3DRS_POINTSIZE_MIN #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a comment with a brief note why the call is made (as described in this PR), so that it's more obvious to future readers of the code? |
|
Sure, can do. |
WinterSnowfall
force-pushed
the
pointsizemin
branch
from
272cf70 to
ab973f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor nitpick, though some games may be affected by it in the end.
The default value of D3DRS_POINTSIZE_MIN in D3D9 is 1.0f, whereas it is 0.0f in D3D8:
This needs to be propagated both on device creation and on subsequent device resets.
Besides the documentation hinting at these defaults, I wrote a test to verify them against native d3d8 and d3d9, and they are indeed as stated (thus in need of correction).