Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return D3D_OK for Set/GetRenderState calls with D3DRS_ZVISIBLE #173

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Return D3D_OK for Set/GetRenderState calls with D3DRS_ZVISIBLE #173

merged 1 commit into from
Sep 8, 2024

Conversation

WinterSnowfall
Copy link
Contributor

@WinterSnowfall WinterSnowfall commented Sep 7, 2024

Tests on Windows XP have shown that these particular calls don't actually error out for D3DRS_ZVISIBLE, but simply return D3D_OK. Also, the default value of D3DRS_ZVISIBLE is 0.

@WinterSnowfall WinterSnowfall marked this pull request as draft September 7, 2024 14:53
@WinterSnowfall WinterSnowfall changed the title Return D3D_OK for SetRenderState calls with D3DRS_ZVISIBLE Return D3D_OK for Set/GetRenderState calls with D3DRS_ZVISIBLE Sep 7, 2024
@WinterSnowfall WinterSnowfall marked this pull request as ready for review September 7, 2024 15:07
@elishacloud
Copy link
Contributor

I believe this is a good change.

I just tested and it seems like SetRenderState() and GetRenderState() should always return DD_OK as long as the State is less than or equal to 255, even if unsupported States are specified. In fact, it might even return DD_OK if the state is greater than 255. I don't see anything in the documentation about it returning anything bu DD_OK.

@crosire crosire merged commit 46f8e4b into crosire:main Sep 8, 2024
@WinterSnowfall WinterSnowfall deleted the d3drs_zvisible branch September 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants