Update pool type in CreateOffscreenPlainSurface() #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request has two changes in it:
D3DPOOL_SCRATCH
rather thanD3DPOOL_SYSTEMMEM
.First of all, this better simulates how DirectX 8 works. Microsoft documents in CreateOffscreenPlainSurface that:
Secondly, this fixes the issue with Forsaken World mentioned here.
D3DPRESENTFLAG_LOCKABLE_BACKBUFFER
flag.These two flags are not compatible which each other in DirectX 9. However, this is much safer than before. If you remove the multi-sample flag the you could lose is anti-aliasing. However, if you remove the
D3DPRESENTFLAG_LOCKABLE_BACKBUFFER
flag the game could crash.