Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pool type in CreateOffscreenPlainSurface() #104

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

elishacloud
Copy link
Contributor

Pull request has two changes in it:

  1. This changes CreateOffscreenPlainSurface() to use D3DPOOL_SCRATCH rather than D3DPOOL_SYSTEMMEM.

First of all, this better simulates how DirectX 8 works. Microsoft documents in CreateOffscreenPlainSurface that:

D3DPOOL_SCRATCH will return a surface that has identical characteristics to a surface created by the DirectX 8.x method CreateImageSurface.

Secondly, this fixes the issue with Forsaken World mentioned here.

  1. This change will remove the multi-sample flag rather than the D3DPRESENTFLAG_LOCKABLE_BACKBUFFER flag.

These two flags are not compatible which each other in DirectX 9. However, this is much safer than before. If you remove the multi-sample flag the you could lose is anti-aliasing. However, if you remove the D3DPRESENTFLAG_LOCKABLE_BACKBUFFER flag the game could crash.

@crosire crosire merged commit e081ef4 into crosire:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants