Update module (#65)

croquiscom · Jul 19, 2023 · 3f6e040 · 3f6e040
1 parent fff9ba3
commit 3f6e040
Show file tree

Hide file tree

Showing 11 changed files with 854 additions and 1,121 deletions.
diff --git a/TypeScript/eslint-www/.changeset/famous-parents-shop.md b/TypeScript/eslint-www/.changeset/famous-parents-shop.md
@@ -0,0 +1,5 @@
+---
+'@croquiscom/eslint-config-www': minor
+---
+
+update dependencies & typescript-eslint v6
diff --git a/TypeScript/eslint-www/check-expected-result.txt b/TypeScript/eslint-www/check-expected-result.txt
@@ -2,7 +2,7 @@
     6:6   error    Unsafe return of an `any` typed value                                                   @typescript-eslint/no-unsafe-return
    11:7   error    Missing trailing comma                                                                  comma-dangle
    15:14  error    Expected { after 'if' condition                                                         curly
-   19:5   error    ["bar"] is better written in dot notation                                               dot-notation
+   19:5   error    ["bar"] is better written in dot notation                                               @typescript-eslint/dot-notation
    22:3   error    Expected '===' and instead saw '=='                                                     eqeqeq
    25:1   error    Missing '()' invoking a constructor                                                     new-parens
    30:5   error    Expected a conditional expression and instead saw an assignment                         no-cond-assign

diff --git a/TypeScript/eslint-www/index.js b/TypeScript/eslint-www/index.js
@@ -9,6 +9,7 @@ module.exports = {
     'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/stylistic',
     'plugin:import/errors',
     'plugin:import/warnings',
     'plugin:import/typescript',

diff --git a/TypeScript/eslint-www/package-lock.json b/TypeScript/eslint-www/package-lock.json
diff --git a/TypeScript/eslint-www/package.json b/TypeScript/eslint-www/package.json
@@ -21,18 +21,18 @@
     "url": "https://github.com/croquiscom/style-guide/issues"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.50.0",
-    "@typescript-eslint/parser": "^5.50.0",
+    "@typescript-eslint/eslint-plugin": "^6.1.0",
+    "@typescript-eslint/parser": "^6.1.0",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-hooks": "^4.6.0"
   },
   "devDependencies": {
-    "@changesets/cli": "^2.26.0",
-    "eslint": "^8.33.0",
+    "@changesets/cli": "^2.26.2",
+    "eslint": "^8.45.0",
     "react": "^18.2.0",
-    "typescript": "^4.9.5"
+    "typescript": "^5.1.6"
   },
   "peerDependencies": {
     "eslint": ">= 6",

diff --git a/TypeScript/eslint-www/requiring-type-checking.js b/TypeScript/eslint-www/requiring-type-checking.js
@@ -1,11 +1,37 @@
 module.exports = {
-  extends: ['./index', 'plugin:@typescript-eslint/recommended-requiring-type-checking'],
+  extends: [
+    './index',
+    'plugin:@typescript-eslint/recommended-type-checked',
+    'plugin:@typescript-eslint/stylistic-type-checked',
+  ],
 
   rules: {
     // indexOf 사용을 허용한다. (클라이언트 코드 때문에)
     '@typescript-eslint/prefer-includes': 'off',
 
     // unbound method를 허용한다. _.identity 같은 코드가 있다.
     '@typescript-eslint/unbound-method': 'off',
+
+    // reoverride rules by plugin:@typescript-eslint/recommended-type-checked
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-unused-vars': [
+      'warn',
+      {
+        ignoreRestSiblings: true,
+        varsIgnorePattern: '^_',
+        argsIgnorePattern: '^_',
+      },
+    ],
   },
+
+  overrides: [
+    {
+      files: ['*.js'],
+      rules: {
+        '@typescript-eslint/no-unsafe-call': 'off',
+        '@typescript-eslint/no-var-requires': 'off',
+      },
+    },
+  ],
 };
diff --git a/TypeScript/eslint/check-expected-result.txt b/TypeScript/eslint/check-expected-result.txt
@@ -2,7 +2,7 @@
     6:6   error    Unsafe return of an `any` typed value                                                   @typescript-eslint/no-unsafe-return
    11:7   error    Missing trailing comma                                                                  comma-dangle
    15:14  error    Expected { after 'if' condition                                                         curly
-   19:5   error    ["bar"] is better written in dot notation                                               dot-notation
+   19:5   error    ["bar"] is better written in dot notation                                               @typescript-eslint/dot-notation
    22:3   error    Expected '===' and instead saw '=='                                                     eqeqeq
    25:1   error    Missing '()' invoking a constructor                                                     new-parens
    30:5   error    Expected a conditional expression and instead saw an assignment                         no-cond-assign

diff --git a/TypeScript/eslint/index.js b/TypeScript/eslint/index.js
@@ -8,6 +8,7 @@ module.exports = {
     'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/stylistic',
     'plugin:import/errors',
     'plugin:import/warnings',
     'plugin:import/typescript',