New setting: Allow delaying background sync while playing videos #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I ask: why? I personally never had any issues with the way it's working now |
|
The skin I'm using displays a black flash at the top right of the screen when This new setting is defaulting to false, so the existing behavior will remain the same unless someone opt's into it. |
croneter
changed the title
|
Thanks once again!! Merged with 3bf7ae1, your new setting now defaults to true 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #2027. While that change works, I still want to prevent background sync library refreshes (due to new media being added) from happening while playing videos.
The scheduled full sync code prevents it from running while videos are playing (link). I think we should allow the same for background sync.
Changes:
Delay background sync while media is playingsetting to enable similar functionality for the background sync flow. It will essentially keep storing websocket messages and process them once you are no longer playing a video.refreshedproperty a little safer. I saw an error in my logs related to this.