Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in fetch content signature #38

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

marcospassos
Copy link
Member

@marcospassos marcospassos commented Aug 14, 2024

Summary

This PR introduces a BC break to correct an inconsistency in the fetchContent signature, aligning it with the API of all other SDKs.

Although the PR is valid as it is, it would be preferable to wait for the release of React SDK and import the FetchResponse from it instead of the Plug.

The type is exported in this PR:
croct-tech/plug-js#296

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added bc-break This change is not backward-compatible bug Something isn't working labels Aug 14, 2024
Copy link

pkg-pr-new bot commented Sep 10, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@croct/plug-next@38

commit: 05901b7

@marcospassos marcospassos merged commit 68c57de into master Sep 10, 2024
7 checks passed
@marcospassos marcospassos deleted the fix-fetchContent-signature branch September 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-break This change is not backward-compatible bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants