Skip to content
This repository was archived by the owner on Apr 9, 2022. It is now read-only.

Use latest System.Reactive (and .NET Standard 2.0) #54

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TheMulti0
Copy link

Hello,

I have noticed that referencing Kafka-Sharp in a brand new .NET Core 2.0/3.0 app with the latest System.Reactive v4.4.1 layer and kafka-sharp installed, I would run into a classic transitive dependency issue.

When trying to reference types from the reactive library, the compiler will not be able to match the correct one for me, since I reference the latest System.Reactive package, and kafka-sharp brings along the older v3 System.Reactive layers.

Therefore, I upgraded the kafka-sharp.netstandard project to reference the latest System.Reactive library.

The upgrade required targeting .netstandard2.0 rather than .netstandard1.6, and the tests and sample projects to .netcoreapp2.0 rather than .netcoreapp1.1.

Anyway, I have uploaded this fork to NuGet.

Have a good day!
Multi

Copy link
Contributor

@ychuzevi ychuzevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Even with netcoreapp2.0 target, the build seems to be failing though

README.md Outdated
Comment on lines 3 to 8
This is a fork that upgrades the project to target .NET Standard 2.0 and `System.Reactive` v4.

[The link to the merge request to the original project](https://github.com/criteo/kafka-sharp/pull/54)

[The link to the NuGet package of this fork](https://www.nuget.org/packages/TheMulti0.kafka-sharp/)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in the PR

@TheMulti0
Copy link
Author

TheMulti0 commented Jul 23, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants