This repository was archived by the owner on Apr 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Use latest System.Reactive (and .NET Standard 2.0) #54
Open
TheMulti0
wants to merge
7
commits into
criteo:master
Choose a base branch
from
TheMulti0:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychuzevi
suggested changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Even with netcoreapp2.0 target, the build seems to be failing though
README.md
Outdated
Comment on lines
3
to
8
This is a fork that upgrades the project to target .NET Standard 2.0 and `System.Reactive` v4. | ||
|
||
[The link to the merge request to the original project](https://github.com/criteo/kafka-sharp/pull/54) | ||
|
||
[The link to the NuGet package of this fork](https://www.nuget.org/packages/TheMulti0.kafka-sharp/) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be in the PR
Fixed.
The build failure is odd, because as you can the build succeeds on AppVeyor
and locally.
.NET Core 2.0 is supported in the .NET Standard version 2.0.
…On Tue, Jul 21, 2020 at 11:31 AM ychuzevi ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for the PR. Even with netcoreapp2.0 target, the build seems to be
failing though
------------------------------
In README.md
<#54 (comment)>:
> +This is a fork that upgrades the project to target .NET Standard 2.0 and `System.Reactive` v4.
+
+[The link to the merge request to the original project](#54)
+
+[The link to the NuGet package of this fork](https://www.nuget.org/packages/TheMulti0.kafka-sharp/)
+
This should not be in the PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBQU7TQFY7ZQO34BLMQ4SLR4VG4TANCNFSM4OP5KEYA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have noticed that referencing Kafka-Sharp in a brand new .NET Core 2.0/3.0 app with the latest
System.Reactive
v4.4.1 layer andkafka-sharp
installed, I would run into a classic transitive dependency issue.When trying to reference types from the reactive library, the compiler will not be able to match the correct one for me, since I reference the latest
System.Reactive
package, andkafka-sharp
brings along the older v3System.Reactive
layers.Therefore, I upgraded the
kafka-sharp.netstandard
project to reference the latestSystem.Reactive
library.The upgrade required targeting
.netstandard2.0
rather than.netstandard1.6
, and the tests and sample projects to.netcoreapp2.0
rather than.netcoreapp1.1
.Anyway, I have uploaded this fork to NuGet.
Have a good day!
Multi