[CRITEO - Scala 2.10 Fix] Fixed BigDecimal related tests #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit works around a bug in [[BigDecimal.equals]] in Scala 2.10 which fails comparisons with doubles, e.g. BigDecimal(1.1) == 1.1 is false in Scala 2.10, but true in Scala 2.11. See scala/scala@29541c for details.
superbobry
force-pushed
the
big-decimal-fix
branch
from
669efaf to
2abbb58
Compare
|
Could you just add a tag in the title so we do not forgot to revert it once we will migrate to scala 2.11? |
superbobry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit works around a bug in
BigDecimal.equalsin Scala 2.10 which fails comparisons with doubles, e.g. BigDecimal(1.1) == 1.1 is false in Scala 2.10, but true in Scala 2.11.See scala/scala@29541c for details.
An alternative way to implement this is to create separate 2.10 and 2.11 files. I've decided not to do it because the cause of the failures (apart from the whitespace diff) is a known bug in 2.10
BigDecimal.