Add "checksum" option for slave-jar remote_file resource #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not a good practice to apply remote_file resource without checksum, add this option here to allow end users add valid one.
| # @return [String] | ||
| # | ||
| def slave_jar_checksum | ||
| @slave_jar_checksum ||= new_resource.checksum |
There was a problem hiding this comment.
What if new_resource.checksum is nil?
FYI cdacfb2
| @@ -211,6 +220,7 @@ def slave_jar_resource | |||
| build_resource(:remote_file, slave_jar).tap do |r| | |||
| # We need to use .tap() to access methods in the provider's scope. | |||
| r.source slave_jar_url | |||
| r.checksum slave_jar_checksum | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is not a good practice to apply remote_file resource without
checksum.
Issues Resolved
This commit will allow end user to add valid checksum value for slave.jar
Check List