Make integration tests for credentials creation pass #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2017 15:16
- Settle on the 'id' attribute as the attr_name for everything, since it is mandatory. - The xml method can now be shared (protected) with the parent class as it would be the same in every subclass. - Reduce the scope of the private key lookup. Due to the way Jenkins stores its credentials, it is quite hard to replicate this logic in integration tests without copying it entirely. As an exercise for later, stop reading credentials.xml and actually query Jenkins, but this is moving towards functional testing.
| @@ -6,30 +6,37 @@ | |||
|
|
|||
| # Test basic password credentials creation | |||
| jenkins_password_credentials 'schisamo' do | |||
| id 'schisamo' | |||
| username 'schisamo' | |||
There was a problem hiding this comment.
The username attribute is not required, since it is the name attribute. I would leave that out here as well and in the following resources.
Let's add it back on our own version of the cookbook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mandatory.
would be the same in every subclass.
its credentials, it is quite hard to replicate this logic in integration
tests without copying it entirely. As an exercise for later, stop reading
credentials.xml and actually query Jenkins, but this is moving towards
functional testing.
Description
Make us more confident that further changes in the credentials part of the cookbook do the right thing. This will be important for #9