Adds flag for changing the default domain.dev
#71
Conversation
cstadach
changed the title
.dev #70.dev
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 82.41% 81.97% -0.45%
==========================================
Files 10 10
Lines 290 294 +4
==========================================
+ Hits 239 241 +2
- Misses 37 38 +1
- Partials 14 15 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hey @cstadach thanks for your contributions.
I left some comments about your PR. Please take a look on them.
| @@ -98,6 +99,9 @@ func command() func() { | |||
| command.BoolVar(&config.Verbose, "V", false, "Set verbosity on proxy output") | |||
|
|
|||
| command.Parse(os.Args[2:]) | |||
| if !strings.HasPrefix(config.Domain, ".") { | |||
There was a problem hiding this comment.
Could we add a test for it? We already have some tests that cover returning no command it can be used as example
There was a problem hiding this comment.
I added the test in commit 9aa188e
commands/run.go
Outdated
| @@ -13,6 +14,7 @@ import ( | |||
| func Run(config *proxy.Config) { | |||
|
|
|||
| fmt.Println("Ergo Proxy listening on port: " + config.Port) | |||
| fmt.Println("Ergo Proxy listening for domain: " + config.Domain) | |||
There was a problem hiding this comment.
Could we avoid repeat the "Ergo proxy listening" sentence? How about?
fmt.Println("Ergo Proxy listening on port " + config.Port + " for domains " + config.Domain)There was a problem hiding this comment.
Good idea.
I pushed the text changes already.
main.go
Outdated
| @@ -30,6 +31,7 @@ Options: | |||
| -h Shows this message. | |||
| -v Shows ergo's version. | |||
| -config Set the config file to the proxy. | |||
| -domain Set the domain the proxy is running. | |||
There was a problem hiding this comment.
This sounds strange. How about "Set a custom domain for services"?
main.go
Outdated
| @@ -49,6 +51,7 @@ func command() func() { | |||
| config := proxy.NewConfig() | |||
| command := flag.NewFlagSet(os.Args[1], flag.ExitOnError) | |||
| configFile := command.String("config", "./.ergo", "Set the services file") | |||
| domain := command.String("domain", ".dev", "Set the doamin for the proxy service") | |||
There was a problem hiding this comment.
Same suggestion as above
|
Hey @cstadach Thanks! |
|
usage for |
|
Is it possible to use with more than one domain extension? I was using some vagrant boxes that had their own IP and no need for ports. So my urls were like: |
these changes should make it possible to change the default
.devdomain to whatever you wantresolves #70