self-xdsd#109 Changed AssignedTasks Chron From 6h to 30min.

criske · May 11, 2021 · bafc222 · bafc222
1 parent 8bcf4a8
commit bafc222
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/main/java/com/selfxdsd/selfpm/ReviewAssignedTasks.java b/src/main/java/com/selfxdsd/selfpm/ReviewAssignedTasks.java
@@ -43,7 +43,7 @@ public final class ReviewAssignedTasks {
     /**
      * The PMs will review the assigned tasks every 6 hours.
      */
-    private static final int EVERY_6_HOURS = 21600000;
+    static final String EVERY_30_MINUTES = "PT30M";
 
     /**
      * Logger.
@@ -69,7 +69,7 @@ public ReviewAssignedTasks(final Self selfCode) {
     /**
      * Every 6 hours the PMs should verify their assigned tasks.
      */
-    @Scheduled(fixedRate = EVERY_6_HOURS)
+    @Scheduled(fixedRateString = EVERY_30_MINUTES)
     public void reviewAssignedTasks() {
         LOG.debug("PMs reviewing their assigned tasks...");
         for(final ProjectManager manager : this.selfCore.projectManagers()) {

diff --git a/src/test/java/com/selfxdsd/selfpm/ReviewAssignedTasksTestCase.java b/src/test/java/com/selfxdsd/selfpm/ReviewAssignedTasksTestCase.java
@@ -23,9 +23,12 @@
 package com.selfxdsd.selfpm;
 
 import com.selfxdsd.api.*;
+import org.hamcrest.MatcherAssert;
+import org.hamcrest.Matchers;
 import org.junit.Test;
 import org.mockito.Mockito;
 
+import java.time.Duration;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -139,4 +142,15 @@ public void reviewsProjectsWithException() {
         }
     }
 
+    /**
+     * Review period has correct format.
+     */
+    @Test
+    public void reviewPeriodHasCorrectFormat() {
+        MatcherAssert.assertThat(
+            Duration.parse(ReviewAssignedTasks.EVERY_30_MINUTES),
+            Matchers.equalTo(Duration.ofMinutes(30))
+        );
+    }
+
 }