-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom Weaver schema definitions for CWL #529
Draft
fmigneault
wants to merge
24
commits into
master
Choose a base branch
from
add-weaver-cwl-schemas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hem in CWL packages
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 85.71% 84.28% -1.44%
==========================================
Files 79 78 -1
Lines 18585 16854 -1731
Branches 2847 2562 -285
==========================================
- Hits 15930 14205 -1725
- Misses 1916 1952 +36
+ Partials 739 697 -42 ☔ View full report in Codecov by Sentry. |
…m schemas by CWL tool + fix resolution of Weaver/CUDA legacy CWL requirements + test no warn during load weaver:WPS1Requirement
…not working as intended
…ut preemptive raising if not yet map by other vars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
feature/CWL
Issue related to CWL support
feature/db
Related to database or datatype manipulation.
feature/oas
Issues related to OpenAPI specifications.
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids warnings about "unknown hints" when loading custom CWL requirements for remote process references.
Previously, custom requirements would have to be loaded as
hints
since they were not technically defined.With this change, they would be also valid using explicit
requirements
.