Add InitCNIWithCache to set the cni cache directory#84
Merged
openshift-merge-robot merged 1 commit intocri-o:masterfrom Mar 1, 2021
Merged
Add InitCNIWithCache to set the cni cache directory#84openshift-merge-robot merged 1 commit intocri-o:masterfrom
openshift-merge-robot merged 1 commit intocri-o:masterfrom
Conversation
Add a new function InitCNIWithCache which works like InitCNI except that it accepts an extra parameter to set the cache directory. This change is needed for rootless users which are trying to use cni in a user+net namespace because the default directory is not writeable by rootless users. Second, setting the cni cache directory via the runtime config is deprecated. It has to be set with NewCNIConfigWithCacheDir for the cni config. see: containernetworking/cni#682 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
openshift-ci-robot
added
dco-signoff: yes
Contributor
Author
|
This is needed for containers/podman#9423 |
Contributor
Author
|
@rhatdan @baude @mheon @vrothberg PTAL |
openshift-ci-robot
added
release-note
Contributor
|
/approve |
rhatdan
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new function InitCNIWithCache which works like
InitCNI except that it accepts an extra parameter to
set the cache directory.
This change is needed for rootless users which are
trying to use cni in a user+net namespace because the
default directory is not writeable by rootless users.
Second, setting the cni cache directory via the runtime
config is deprecated. It has to be set with
NewCNIConfigWithCacheDir for the cni config.
see: containernetworking/cni#682