Skip to content

ocicni: add support of specifying static MACs #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 20, 2019
Merged

ocicni: add support of specifying static MACs #61

openshift-merge-robot merged 1 commit into from
Sep 20, 2019

Conversation

@filak-sap
Copy link
Contributor

@filak-sap filak-sap commented Sep 18, 2019

Add the parameter MAC to CNI_ARGS.

I copied the approach from the plugin tunning and github.com/intel/multus-cni.

@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Sep 18, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2019
@filak-sap
Copy link
Contributor Author

filak-sap commented Sep 18, 2019

Ouch - I got 404 when opening https://github.com/cri-o/ocicni/blob/master/CONTRIBUTING.md as suggested in the comment above.

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 18, 2019
@filak-sap
ocicni: add support of specifying static MACs
42f7586 
Add the parameter MAC to CNI_ARGS.

I copied the approach from the plugin tunning and github.com/intel/multus-cni.

Signed-off-by: Jakub Filak <[email protected]>
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2019
@filak-sap filak-sap mentioned this pull request Sep 18, 2019
Closed
@mheon
Copy link
Contributor

mheon commented Sep 18, 2019

This is a request from the Podman side, to allow containers to specify custom MAC addresses in the same way they specify custom IPs

@dcbw
Copy link
Collaborator

dcbw commented Sep 18, 2019

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@mheon
Copy link
Contributor

mheon commented Sep 18, 2019

@dcbw Think you misspelled the /approve

@rhatdan
Copy link
Contributor

rhatdan commented Sep 19, 2019

Worth a try
/approve

@rhatdan
Copy link
Contributor

rhatdan commented Sep 20, 2019

@rajatchopra @sameo @dcbw @mrunalp could one of you /approve this so we can get it into podman?

@mrunalp
Copy link
Member

mrunalp commented Sep 20, 2019

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filak-sap, mccv1r0, mrunalp, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit deac903 into cri-o:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@mrunalp mrunalp Awaiting requested review from mrunalp

1 more reviewer

@mccv1r0 mccv1r0 mccv1r0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@filak-sap @mheon @dcbw @rhatdan @mrunalp @openshift-ci-robot @mccv1r0 @openshift-merge-robot