Skip to content

Conversation

@vrothberg
Copy link
Member

Some APIs of containernetworking/cni now require a context.Context
argument.

Signed-off-by: Valentin Rothberg rothberg@redhat.com

Some APIs of containernetworking/cni now require a context.Context
argument.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg
Copy link
Member Author

We're currently blocked updating CNI due to the API changes.

@dcbw @mrunalp @vbatts @mheon @baude PTAL

Copy link

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming happy tests

@mrunalp
Copy link
Member

mrunalp commented Mar 28, 2019

LGTM

@mrunalp mrunalp merged commit 0c180f9 into cri-o:master Mar 28, 2019
@vrothberg vrothberg deleted the update-cni branch March 28, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants